feat: analytics refactoring #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we need to delete extra analytics code from this repo ? |
niktverd
force-pushed
the
feat/analytics
branch
from
038482b to
ea26782
Compare
|
Preview is ready. |
niktverd
force-pushed
the
feat/analytics
branch
2 times, most recently
from
48bef43 to
b4c2d31
Compare
We need it until we get 'ok' that new analytics in working properly |
NikitaCG
reviewed
Apr 7, 2023
| @@ -70,9 +83,16 @@ export const Controls: React.FC<ControlsProps> = ({ | |||
| }; | |||
|
|
|||
| const handleTagSelect = (selectedTags: string[]) => { | |||
| /** | |||
| * @deprecated Metrika will be deleted after launch of analyticsEvents | |||
| * https://st.yandex-team.ru/PAGECTR-7 | |||
There was a problem hiding this comment.
i think we don't need to write info about tickets
NikitaCG
approved these changes
Apr 7, 2023
NikitaCG
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.