feat: use appropriate heading levels for blog post cards #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
NikitaCG
requested changes
Aug 18, 2023
src/components/PostCard/PostCard.tsx
Outdated
| @@ -9,25 +9,30 @@ import {SuggestPostInfo} from '../PostInfo/SuggestPostInfo'; | |||
|
|
|||
| import './PostCard.scss'; | |||
|
|
|||
| const b = block('post-card'); | |||
| type PostCardSize = 's' | 'm'; | |||
| type TitleHeadingLevel = 'h2' | 'h3'; | |||
There was a problem hiding this comment.
Can we make an enum for these values ? And we can use it in another files https://github.com/gravity-ui/blog-constructor/pull/103/files#diff-112399abf9eaac816425b4c2015f063a593c518e0ccff35b04814de737bae3beR59
NikitaCG
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes heading tags used for better semantics. In the page one should not bypass the heading levels (e.g. from h1 to h4, as done in the current version)