fix(worker): fix public path in worker #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValeraS
requested changes
Mar 11, 2024
| @@ -24,7 +24,7 @@ export {WebWorker as Worker, SharedWebWorker as SharedWorker}; | |||
|
|
|||
| function generateWorkerLoader(url: string | URL) { | |||
| // eslint-disable-next-line camelcase | |||
| const publicPath = __webpack_public_path__; | |||
| const publicPath = __webpack_public_path__ === '' ? '/' : __webpack_public_path__; | |||
| const workerPublicPath = publicPath.match(/^https?:\/\//) | |||
| ? publicPath | |||
| : new URL(publicPath, window.location.href).toString(); | |||
There was a problem hiding this comment.
Does it fix the problem?
Suggested change
| : new URL(publicPath, window.location.href).toString(); | |
| : new URL(publicPath, window.location.origin).toString(); |
There was a problem hiding this comment.
Yeah, It might works
ValeraS
changed the title
ValeraS
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
Worker doesn't work in storybook because webpack_public_path is empty string and dynamic imports inside worker get wrong public path.