Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge GraphMatch into scipy and refactor GraphMatch to use it #348

Closed
jovo opened this issue May 12, 2020 · 2 comments · Fixed by #542
Closed

merge GraphMatch into scipy and refactor GraphMatch to use it #348

jovo opened this issue May 12, 2020 · 2 comments · Fixed by #542
Assignees
@asaadeldin11
Labels
important

Comments

@jovo
Copy link

jovo commented May 12, 2020

No description provided.

@jovo jovo added the important label May 12, 2020
@bdpedigo bdpedigo changed the title merge into scipy merge GraphMatch into scipy May 12, 2020
@bdpedigo bdpedigo mentioned this issue Aug 14, 2020
Closed
@asaadeldin11 asaadeldin11 mentioned this issue Sep 4, 2020
Closed
@bdpedigo bdpedigo changed the title merge GraphMatch into scipy merge GraphMatch into scipy and refactor GraphMatch to use it Sep 8, 2020
@bdpedigo
Copy link
Collaborator

bdpedigo commented Sep 8, 2020

@asaadeldin11 want to rip out the guts from GraphMatch when your scipy PR is merged/released? or wanna have someone in NDD work on this?

@asaadeldin11
Copy link
Contributor

Yeah I can take care of this once it's merged. It'll probably also be a good idea to update the version of scipy required for graspy once we do this.

@bdpedigo bdpedigo mentioned this issue Sep 16, 2020
Closed
@asaadeldin11 asaadeldin11 mentioned this issue Oct 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asaadeldin11 asaadeldin11

Labels
important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporarily have scipy quadratic_assignment live in graspologic graspologic-org/graspologic
3 participants
@jovo @bdpedigo @asaadeldin11