Skip to content
This repository has been archived by the owner on Jul 31, 2022. It is now read-only.

enhancement: filter out invalid, built-in intellisense/emmet suggestions in (ts/js)x #4

Closed
sorenbs opened this issue Jun 11, 2018 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@sorenbs
Copy link

sorenbs commented Jun 11, 2018

Bringing up auto-complete using ctrl-space shows too many suggestions:

image

Writing the first letter is better:

image

Picking inp will autocomplete like this:

image

Can we fix ctrl-space?

@divyenduz
Copy link
Collaborator

divyenduz commented Jun 11, 2018

@sorenbs : inp, int, uni, enu are snippets. I think VSCode augments them with autosuggest, let me looks for an API to see how much control we have to remove it contextually but I think there is limited support.

@divyenduz
Copy link
Collaborator

Or we can remove snippets from the extension, it is a feature that other extensions provided as well.

@sorenbs
Copy link
Author

sorenbs commented Jun 11, 2018

Ok. They are certainly super confusing when presented out of context like that. Better to remove them I think

@peterschussheim
Copy link

I agree with @sorenbs, snippets should be a separate extension or add a setting to disable.

@marktani marktani added the enhancement New feature or request label Jun 20, 2018
@divyenduz
Copy link
Collaborator

Related: microsoft/vscode#45039

@acao
Copy link
Member

acao commented Sep 4, 2020

oh great! so glad to find this. the vscode developers slack had written this off as impossible last month, and it has been bothering me to no end 😆

this will definately be in 0.3.2

@acao acao added this to the 0.3.2 milestone Sep 4, 2020
@acao acao changed the title ctrl-space shows too many suggestions enhancement: filter out invalid, built-in intellisense/emmet suggestions in (ts/js)x Sep 4, 2020
@acao
Copy link
Member

acao commented Sep 18, 2020

I've updated the README with instructions on how to configure this for yourself, as we don't have a way to programatically set this setting for users

https://github.com/prisma-labs/vscode-graphql#in-jsx-and-tsx-files-i-see-completion-items-i-dont-need

you may have to disable a few other types beyond just snippets. if you still have issues after this, please open another ticket!

@acao acao closed this as completed Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants