-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphiQL onEditQuery
is called without query argument after TypeScript migration
#1439
Comments
this might be a good candidate for a hotfix to backport |
or wait, so this is only an issue in alpha, as 0.17.5 was before the typescript migration |
@acao right! I had the issue in 1.0.0-alpha.1/3, so no need to backport |
great! thanks for this, we can get another alpha out here shortly. I'll close this once it's been released. glad the new typescript types are working out for you 😄 |
pre-release is out, find 1.0.0-alpha.4 :) |
use latest alpha btw! @cshaver lemme know if you have any issues |
I'm updating our installation of graphiql to
1.0.0-alpha.1
, and thanks to the new TypeScript types (🎉) I was was really quickly made aware that the type signature of the function passed toGraphiQL
as theonEditQuery
prop has changed:This breaks our usage of graphiql-explorer. (see example setup which uses
onEditQuery
https://github.com/OneGraph/graphiql-explorer-example/blob/master/src/App.js#L189)It looks like this change was made in the recent TypeScript migration.
I understand that this prop is likely going to be deprecated in the new API per #1165, but it looks to me like this change was unintentional (
onEditQuery
is unchanged in the README, and per #1242 (comment) that this should have minimal production changes).The text was updated successfully, but these errors were encountered: