Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for setImmediate fallback #210

Closed
leebyron opened this issue Nov 7, 2019 · 0 comments · Fixed by #221
Closed

Add test for setImmediate fallback #210

leebyron opened this issue Nov 7, 2019 · 0 comments · Fixed by #221

Comments

@leebyron
Copy link
Contributor

leebyron commented Nov 7, 2019

Updated coveralls shows a < 100% coverage, and this condition is what is not yet under test.

Will need to mock out process.nextTick, may need to migrate to Jest to make this test decent.

In general we need a set of "browser tests" since the browser's runtime loop is subtly different from Node's and DataLoader leverages Node's runtime loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant