Nested imported fragments can give false positives on unique-fragment-name

[lennartbuit]

Describe the bug

When a query imports a fragment (using #import) that itself also imports another fragment, all documents are reported as to having a duplicate fragment names.

To Reproduce

Check out this gist: https://gist.github.com/lennartbuit/3d0141b62432c133ca553de15792ad17

In this setup, I have a query importing fragment A that itself imports fragment B.

Running yarn eslint *.graphql will flag all files as having violations of the unique-fragment-name rule:

Expected behavior

No reported errors. Fragments are only defined once, after all.

Environment:

• OS: Mac OS
• @graphql-eslint/...: 1.1.0
• NodeJS: v14.16.1

Additional context

[lennartbuit]

[I can spin this out in a seperate issue if you'd like] The @graphql-eslint/no-unused-fragments also doesn't handle this situation of nested imports correctly:

I would have expected fragments to be considered used if they were imported by imports of intermediate fragments.

[dimaMachina]

Thank you @lennartbuit your description is very helpful, we'll fix this very soon!

[dotansimha]

Fixed in @graphql-eslint/eslint-plugin@1.1.1

[lennartbuit]

Thank you both! Checked with my original codebase and confirmed fixed these issue[s] there as well!