Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Graph Builders #116

Closed
clue opened this issue Jan 3, 2015 · 2 comments
Closed

Consolidate Graph Builders #116

clue opened this issue Jan 3, 2015 · 2 comments

Comments

@clue
Copy link
Member

clue commented Jan 3, 2015

We currently have several classes that are concerned with creating / building graphs from certain parameters or input graphs:

IMHO both Algorithm and Loader are bad descriptions and do not quite describe their responsibility. As a first step, I'd vote for grouping these in a new Builder (or similar) namespace. In the future we should work out a decent API (interface).

Refs #120.

@clue
Copy link
Member Author

clue commented Jan 12, 2015

The name "Builder" will probably be confusing with regards to the builder pattern.

Ticket #119 suggests we should stabilize the core graph library and split off optional sub-namespaces. The suggested Builder namespace would probably be one such candidate, and as such we should probably avoid introducting yet another namespace in the first place.

Instead, I'd suggest we should move the CompleteGraph into the Algorithm namespace. This will obsolete this issue.

@clue
Copy link
Member Author

clue commented Jan 23, 2015

The name "Builder" will probably be confusing with regards to the builder pattern.

Marking this ticket as invalid.

Instead, I'd suggest we should move the CompleteGraph into the Algorithm namespace. This will obsolete this issue.

Loaders will be split off via #117, algorithms will be split off via #119.
As such, this is blocked until both issues have been resolved.
I've filed two new tickets that keep track of this state.

@clue clue closed this as completed Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant