You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IMHO both Algorithm and Loader are bad descriptions and do not quite describe their responsibility. As a first step, I'd vote for grouping these in a new Builder (or similar) namespace. In the future we should work out a decent API (interface).
The name "Builder" will probably be confusing with regards to the builder pattern.
Ticket #119 suggests we should stabilize the core graph library and split off optional sub-namespaces. The suggested Builder namespace would probably be one such candidate, and as such we should probably avoid introducting yet another namespace in the first place.
Instead, I'd suggest we should move the CompleteGraph into the Algorithm namespace. This will obsolete this issue.
The name "Builder" will probably be confusing with regards to the builder pattern.
Marking this ticket as invalid.
Instead, I'd suggest we should move the CompleteGraph into the Algorithm namespace. This will obsolete this issue.
Loaders will be split off via #117, algorithms will be split off via #119.
As such, this is blocked until both issues have been resolved.
I've filed two new tickets that keep track of this state.
We currently have several classes that are concerned with creating / building graphs from certain parameters or input graphs:
Algorithm\ResidualGraph
Algorithm\TransposeGraph
Loader\CompleteGraph
ComplementGraph
(see Add complement Graph algorithm / builder #60)IMHO both
Algorithm
andLoader
are bad descriptions and do not quite describe their responsibility. As a first step, I'd vote for grouping these in a newBuilder
(or similar) namespace. In the future we should work out a decent API (interface).Refs #120.
The text was updated successfully, but these errors were encountered: