This repository has been archived by the owner on Nov 24, 2018. It is now read-only.
allow key prefix for all s3 images, configured via environment #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adieuadieu
suggested changes
Aug 12, 2017
There was a problem hiding this comment.
Hi @pklingem — Thank you for raising this PR. Out of curiosity: Is the s3 bucket limit something you're coming up against? Does this PR solve your use-case?
One nit picky request: let's rename CHROMELESS_S3_BUCKET_KEY_PREFIX to CHROMELESS_S3_OBJECT_KEY_PREFIX
|
@adieuadieu agreed that is a better variable name, I've pushed a commit to update the name. Yes, we've encountered the bucket limit at my company @articulate and we've consolidated our buckets. I have a working proof of concept of my fork of chromeless replacing a nightmare based tool we built, this PR is the only thing preventing us from moving to production with this. Thank you for considering this change! |
adieuadieu
approved these changes
Aug 12, 2017
schickling
approved these changes
Aug 12, 2017
|
Thank you, @pklingem! |
Closed
webpolis
pushed a commit
to webpolis/yb-chromeless
that referenced
this pull request
Oct 5, 2017
allow key prefix for all s3 images, configured via environment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of s3 buckets is limited per account in s3. As such, a common pattern is to use a single bucket and prefix the keys for s3 objects per app, etc. This PR enables key prefixing.