Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Event Bug and v3 #55

Closed
grantcarthew opened this issue Feb 17, 2017 · 1 comment
Closed

Error Event Bug and v3 #55

grantcarthew opened this issue Feb 17, 2017 · 1 comment
Labels

Comments

@grantcarthew
Copy link
Owner

I had a few hours up my sleeve and decided to write the last couple of tests to get the coverage up.

In doing so I discovered an API design flaw which caused an exception whilst throwing error events.

I posted on the Nodejs Help repository and @bnoordhuis has raised a pull request for Nodejs.

To fix this error I will need to change the public API for rethinkdb-job-queue which in turn means bumping the version up to the next major version due to SemVer.

The specific Public API change will be moving from having the Queue.id as the first argument for all events to having error objects as the first argument for error events. I will add the Queue.id to the error objects before raising the event.

@grantcarthew
Copy link
Owner Author

v3 published fixing the error event API issue.
Please read Event.error for the error event syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant