Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow renaming repositories #471

Closed
gustavi opened this issue Jul 18, 2024 · 7 comments
Closed

Allow renaming repositories #471

gustavi opened this issue Jul 18, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@gustavi
Copy link
Contributor

gustavi commented Jul 18, 2024

Description

We can edit notes or add tags but repositories can't be renamed.

How to reproduce

  1. Create a repository
  2. Edit it (button bottom right)
  3. The name can't be edited

image

Additional information

  • Gramps 5.2.2
  • Gramps Web API 2.3.1
  • Gramps Web Frontend 24.7.0
  • Gramps QL 0.3.0
  • locale: en
  • multi-tree: false
  • task queue: false
@DavidMStraub DavidMStraub changed the title Repositories can't be renamed Allow renaming repositories Jul 18, 2024
@DavidMStraub DavidMStraub added the enhancement New feature or request label Jul 18, 2024
@Naeit
Copy link

Naeit commented Jul 21, 2024

Screenshot_2024-07-21-09-31-49-588_com.android.chrome.jpg

I would like to add that data of Sources are also not editable. Maybe that could be added to, if it is intended to be editable.

Gramps 5.2.2
Gramps Web API 2.3.1
Gramps Web Frontend 24.7.0
Gramps QL 0.3.0
locale: en
multi-tree: true
task queue: true

Gramps Web via grampshub.com

@DavidMStraub
Copy link
Member

That one is tracked in #57.

@gustavi
Copy link
Contributor Author

gustavi commented Aug 1, 2024

@DavidMStraub it's really hard to use. Every time I stop typing for 1s the field is saved and I loose the "input". I have to copy-paste from a text editor to use it.

@DavidMStraub
Copy link
Member

How come you need more than 1 second? 😄

Which browser do you use?

@DavidMStraub
Copy link
Member

And please check if you have the same issue when editing task titles

@gustavi
Copy link
Contributor Author

gustavi commented Aug 5, 2024

How come you need more than 1 second? 😄

I often copy from manual notes, PDF or external website. The time it takes to remember a combination of random numbers or a complicated name of a village in France is much greater than the time available to me. 😄

Which browser do you use?

Firefox LTS.

And please check if you have the same issue when editing task titles

Same issue.

I suggest the following modification: don't trigger the "save" event until the mouse has moved outside the input (or for a very long time, 10s for example). Another option: send periodic saves but keep editing possible until you click elsewhere on the page.

@DavidMStraub
Copy link
Member

I don't see a need to change the behaviour. It works perfectly fine on my end in FF 128. It uses the contenteditable HTML attribute, so no need to watch mouse behaviour. Could be that this older FF version doesn't handle it properly. Works on Chrome as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants