Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time resolution on WASI runner #1824

Open
phated opened this issue Apr 23, 2023 · 1 comment
Open

Time resolution on WASI runner #1824

phated opened this issue Apr 23, 2023 · 1 comment
Labels
WASI

Comments

@phated
Copy link
Member

phated commented Apr 23, 2023

The time resolutions on Windows are pretty bad in our WASI runner (uvwasi). @ospencer tried to fix this in nodejs/uvwasi#182 but 2 subsequent calls to processCpuTime and threadCpuTime result in the same time on Windows.

As of #1585, we're using <= to compare times in the tests, but we should look on making the resolution better on Windows.
@ospencer
Copy link
Member

ospencer commented Apr 5, 2024

These two clocks were removed in WASI Preview 2. We may decide not to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WASI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phated @ospencer @spotandjake