Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grails-web-taglib to test dependencies #13973

Closed
wants to merge 1 commit into from
Closed

Conversation

matrei
Copy link
Contributor

@matrei matrei commented Jan 15, 2025

This is a temporary fix to get the tests working while we sort out the right dependency scopes in grails-gsp.

This is a temporary fix to get the tests working while we sort out the right dependency scopes in `grails-gsp`.
Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just set the scopes back & the imports back in the gsp project? This work around will only help core, and not the other projects that are broken downstream.

@matrei
Copy link
Contributor Author

matrei commented Jan 15, 2025

Why not just set the scopes back & the imports back in the gsp project? This work around will only help core, and not the other projects that are broken downstream.

Yes, that is perhaps a better option 👍

@jdaugherty
Copy link
Contributor

I did this here: https://github.com/grails/grails-gsp/pull/563/files . We should still fix this the "right" way once we have time. But this restores the dependency order as before (minus the api "org.apache.groovy:groovy:$groovyVersion" dependency and it keeps your test dependencies since those work)

@matrei
Copy link
Contributor Author

matrei commented Jan 16, 2025

Used grails/grails-gsp#563 instead.

@matrei matrei closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants