Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAILS-11998: Align with latest changes to HTML5 Boilerplate #1226

Closed
graemerocher opened this issue Feb 18, 2015 · 2 comments
Closed

GRAILS-11998: Align with latest changes to HTML5 Boilerplate #1226

graemerocher opened this issue Feb 18, 2015 · 2 comments

Comments

@graemerocher
Copy link
Member

Original Reporter: ronnylovtangen
Environment: Not Specified
Version: 3.0-M1
Migrated From: http://jira.grails.org/browse/GRAILS-11998

Grails’ default sitemesh layout (main.gsp) is based on HTML5 Boilerplate (https://html5boilerplate.com/) which just recently released v5.0.0.
One of the things they did in v5.0.0 was to drop IE6/IE7 hacks and get rid of the conditional comments, which had some serious issues, making more harm than good (h5bp/html5-boilerplate#1187)
The same issues applies to Grails, and I have been bitten by this at my current customer, which had their domain on Microsofts compatibility view list.

Grails 3 would be a good opportunity to align with the new HTML5 Boilerplate.

Thread on mailinglist: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/grails-dev-discuss/AGgw-82bUIQ/l24IGs5b5sgJ

@graemerocher
Copy link
Member Author

ronnylovtangen said:
Pull request: grails/grails-profile-repository#5

@graemerocher
Copy link
Member Author

graemerocher said:
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant