Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo the broken part of the fix #14

Merged
merged 1 commit into from
Dec 29, 2016
Merged

undo the broken part of the fix #14

merged 1 commit into from
Dec 29, 2016

Conversation

neb9
Copy link
Contributor

@neb9 neb9 commented Dec 28, 2016

the unit tests are good, but this line's change was absolutely broken. this issue was addressed in an issue, but for some reason never added to repo.

the unit tests are good, but this line's change was absolutely broken. this issue was addressed in an issue, but for some reason never added to repo.
@graik
Copy link
Owner

graik commented Dec 28, 2016

Either way ("and" or "or") we get errors from some PDB files, don't we?

@neb9
Copy link
Contributor Author

neb9 commented Dec 28, 2016

The old way works most of the time (when combined with other workarounds) -- the new way does not fix any issue I have seen, and breaks almost every protein. So the old way seems much better, hence this pullreq. It's still not perfect, but it fixes some breakage.

@graik
Copy link
Owner

graik commented Dec 29, 2016 via email

@graik graik merged commit 2e1b7ef into graik:master Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants