Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add password pop-up timeout #501

Closed
PhillyPhoto opened this issue Apr 29, 2024 · 1 comment
Closed

[FR] Add password pop-up timeout #501

PhillyPhoto opened this issue Apr 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@PhillyPhoto
Copy link

PLEASE NOTE THAT FEATURE REQUESTS ARE ONLY CONSIDERED AGAINST v.28.0+

Is your feature request related to a problem? Please describe.
Yes, people could ignore the password prompt window and the script will run forever, causing issues for MDMs like Jamf where other policies may be waiting to run.

Describe the solution you'd like
Update the ask_for_credentials() function to include the following in "dialog_args":
"--timer"
"300"
(or some other time interval)

Describe alternatives you've considered
N/A

Additional context
If max_password_attempts is set to "infinite" the user will just keep getting prompted for their creds. However, they can just ignore the dialog. Having it time out would bring it back in their view again and if there are issues they would be more likely to raise the issue sooner. This would also ensure if someone does use a password that isn't accepted for whatever reason but stop before the max attempts is reached, this would ensure the max attempts does eventually get reached and allow the script to fail in a timely manner.

@PhillyPhoto PhillyPhoto added the enhancement New feature or request label Apr 29, 2024
@grahampugh
Copy link
Owner

This is addressed in v35.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants