Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate BrowserContext APIs to async #1295

Closed
6 tasks done
Tracked by #428
ankur22 opened this issue May 2, 2024 · 0 comments
Closed
6 tasks done
Tracked by #428

Migrate BrowserContext APIs to async #1295

ankur22 opened this issue May 2, 2024 · 0 comments
Assignees
@inancgumus
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes browser context Issues and PRs related to browser context

Comments

@ankur22
Copy link
Collaborator

ankur22 commented May 2, 2024 •
edited by inancgumus
Loading

Tasks
Preview Give feedback
  1. Fix page and context mappings #1326
    bug mapping
    inancgumus
  2. Prepare BrowserContext for async migration #1327
    mapping refactor stability
    inancgumus
  3. Async BrowserContext #1328
    async breaking browser context mapping
    inancgumus
  4. Update to Async BrowserContext k6-docs#1590
    Area: browser
    inancgumus
  5. Update Browser/BrowserContext API:s to return Promise k6-DefinitelyTyped#44
    browser
    allansson

What

Migrate the following APIs according to the How section in #428:

Class Method Current k6 Return PW return
BrowserContext addCookies void Promise
BrowserContext addInitScript void not found in Playwright
BrowserContext browser Browser null|Browser
BrowserContext clearCookies void Promise
BrowserContext clearPermissions void Promise
BrowserContext close void Promise
BrowserContext cookies Cookie[] Promise<Array>
BrowserContext grantPermissions void Promise
BrowserContext newPage Page Promise
BrowserContext setGeolocation void Promise
BrowserContext setOffline void Promise

For details on the Why and How, check the overarching issue in #428.
@ankur22 ankur22 mentioned this issue May 2, 2024
Closed
@ankur22 ankur22 added the async supports async (promises) label May 2, 2024
@inancgumus inancgumus added the breaking PRs that need to be mentioned in the breaking changes section of the release notes label May 6, 2024
@inancgumus inancgumus self-assigned this May 9, 2024
This was referenced May 10, 2024
Merged
Merged
@inancgumus inancgumus added the browser context Issues and PRs related to browser context label May 10, 2024
@inancgumus inancgumus mentioned this issue May 20, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inancgumus inancgumus

Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes browser context Issues and PRs related to browser context
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inancgumus @ankur22