Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --{tla,ext}-{code,str}-file flag in "tk eval" #1238

Merged

Conversation

rudo-thomas
Copy link
Contributor

@rudo-thomas rudo-thomas commented Nov 22, 2024

Convert the flag values to import/importstr @"verbatim ""quoted"" string",
pretty much like go-jsonnet does it.

Implements #848

Convert the flag values to `import/importstr @"verbatim ""quoted"" string"`,
pretty much like go-jsonnet does it.

Implements grafana#848
@rudo-thomas rudo-thomas force-pushed the fix-tla-str-quoting-02-implement-file-flags branch from cee1b4b to 1cd86d2 Compare November 22, 2024 10:08
@rudo-thomas
Copy link
Contributor Author

@zerok can you take a look please? :)

Copy link
Contributor

@zerok zerok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this 🙂 Looks good, just left a small question.

cmd/tk/flags.go Show resolved Hide resolved
@zerok zerok enabled auto-merge December 2, 2024 11:59
@rudo-thomas
Copy link
Contributor Author

This didn't get merged for some reason...
@zerok Could you PTAL?

@zerok zerok added this pull request to the merge queue Dec 16, 2024
@zerok
Copy link
Contributor

zerok commented Dec 16, 2024

Sorry, missed that on my list. Thank you again 🙂

Merged via the queue into grafana:main with commit a93627a Dec 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants