-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow checks to run less often #611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
force-pushed
the
allow-lower-frequencies
branch
from
February 22, 2024 22:31
b412e14
to
74d7a5a
Compare
ka3de
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was nice! 👏 Made a couple of comments.
mem
force-pushed
the
allow-lower-frequencies
branch
from
February 28, 2024 18:55
74d7a5a
to
8cdacf0
Compare
ka3de
approved these changes
Feb 29, 2024
mem
force-pushed
the
allow-lower-frequencies
branch
from
March 5, 2024 14:44
8cdacf0
to
07ec23c
Compare
This change allows a check to run less often by storing the produced metrics and pushing the last set that was produced by the scraper once every 2 minutes. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
force-pushed
the
allow-lower-frequencies
branch
from
March 5, 2024 14:50
07ec23c
to
b61761a
Compare
ka3de
added a commit
that referenced
this pull request
Mar 11, 2024
* Send adhoc check done logs to Loki without --verbose (#631) * Chore(deps): Bump github.com/prometheus/prometheus from 0.50.0 to 0.50.1 * Configure blacklist ip range for k6 runner (#633) * Add telemetry (#621) * Fix: telemetry region label (#638) * Chore(deps): Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#640) * Chore(deps): Bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#628) * Chore(deps): Bump golang.org/x/net from 0.21.0 to 0.22.0 (#642) * Chore(deps): Bump github.com/prometheus/common from 0.47.0 to 0.49.0 * use expfmt.NewFormat instead of now-private formats directly * Feature: allow checks to run less often (#611) * Upgrade to grafana-build-tools v0.6.1 (#646) * Fix telemetry error handling (#650) * Use github.com/grafana/loki/pkg/pusher instead of logproto (#648) * Pass a scraper factory from main (#649) * Chore(deps): Bump google.golang.org/grpc from 1.62.0 to 1.62.1 * Chore(deps): Bump github.com/prometheus/common from 0.49.0 to 0.50.0 * Add telemetry sampled executions (#653) Signed-off-by: ka3de <danijs12@hotmail.com>
Merged
ka3de
added a commit
that referenced
this pull request
Mar 11, 2024
* Send adhoc check done logs to Loki without --verbose (#631) * Chore(deps): Bump github.com/prometheus/prometheus from 0.50.0 to 0.50.1 * Configure blacklist ip range for k6 runner (#633) * Add telemetry (#621) * Fix: telemetry region label (#638) * Chore(deps): Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#640) * Chore(deps): Bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#628) * Chore(deps): Bump golang.org/x/net from 0.21.0 to 0.22.0 (#642) * Chore(deps): Bump github.com/prometheus/common from 0.47.0 to 0.49.0 * use expfmt.NewFormat instead of now-private formats directly * Feature: allow checks to run less often (#611) * Upgrade to grafana-build-tools v0.6.1 (#646) * Fix telemetry error handling (#650) * Use github.com/grafana/loki/pkg/pusher instead of logproto (#648) * Pass a scraper factory from main (#649) * Chore(deps): Bump google.golang.org/grpc from 1.62.0 to 1.62.1 * Chore(deps): Bump github.com/prometheus/common from 0.49.0 to 0.50.0 * Add telemetry sampled executions (#653) Signed-off-by: ka3de <danijs12@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows a check to run less often by storing the produced metrics and pushing the last set that was produced by the scraper once every 2 minutes.