Feature: add log labels to log entries #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minimal change to support adding the log labels to the log entries themselves. In the future we would like to remove user-defined labels from the labels and keep them in the log entries only in order to allow users to add _more_ labels, but this change is not that. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
rdubrock
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal change to support adding the log labels to the log
entries themselves.
In the future we would like to remove user-defined labels from the
labels and keep them in the log entries only in order to allow users to
add more labels, but this change is not that.
Signed-off-by: Marcelo E. Magallon marcelo.magallon@grafana.com