Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about pyroscope sdk and ebpf api #2726

Closed
DFSOrange opened this issue Nov 18, 2023 · 2 comments
Closed

question about pyroscope sdk and ebpf api #2726

DFSOrange opened this issue Nov 18, 2023 · 2 comments

Comments

@DFSOrange
Copy link

Why does the SDK use the /ingest API while the eBPF injection uses the pushservice API? Is it because of performance considerations? Was there a previous intermediate version of eBPF that used the ingest API for reporting performance?
@cyriltovena
Copy link
Contributor

/ingest is the first version of pyroscope, pushservice API is the new API which is based of pprof and recommended as of now. OTEL will most likely be the future and we'll have a 3 API for ingesting :) open-telemetry/oteps#239

We keep the /ingest because it support more other format such jfr from java which is handy.

@cyriltovena
Copy link
Contributor

Let me know if you have more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyriltovena @DFSOrange