store-gateway: reduce garbage from index header #10715
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This one call to io.ReadAll was generating 6% of all garbage in some production store-gateways recently.
Since gzip puts the size at the end of the compressed data, we can use that size to pre-allocate the buffer and avoid resizing.
Code is adapted from some that used to be inside gRPC, from grpc/grpc-go#3048
It is annoying to add 16 lines of code for this benefit, so I looked at whether we could have a utility function doing it.
pkg/util/http.go
has similar code but also handles LZ4.pkg/distributor/otel.go
also handles gzip and LZ4, and pools the buffers.Both of the above, and some other similar places, have a maximum size they will read.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.