Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: persistent cache item_size_max: 5242880 cannot be larger than ext_wbuf_size: 4194304 #14028

Closed
rknightion opened this issue Sep 2, 2024 · 1 comment · Fixed by #14049

Comments

@rknightion
Copy link

rknightion commented Sep 2, 2024

Describe the bug
In the latest helm chart that adds persistent memcached, the default chart values lead to a failure of memcached to start with:
persistent cache item_size_max: 5242880 cannot be larger than ext_wbuf_size: 4194304
This is on both the chunks and results cache

This will be because the item_size_max is set to 5mb.

Additionally, I can see the template does the following:
--extended=modern,track_sizes{{ if .persistence.enabled }},ext_path={{ .persistence.mountPath }}/file:{{ .persistence.storageSize }}{{ end }}{{ with .extraExtendedOptions }},{{ . }}{{ end }}
However the docs on this at https://github.com/memcached/memcached/wiki/ConfiguringLokiExtstore indicate a few more settings need changing or optimising such as:

  • ext_wbuf_size (the cause of this issue I think)
  • ext_threads
  • ext_max_sleep
  • slab_automove_freeratio

Simply enabling ext cache without doing any of the other performance tweaks I worry could lead users to a subpar experience?
This should at least be documented somewhere if the feat isn't 'complete'?

To Reproduce
Steps to reproduce the behavior:
Set chunksCache.persistence.enabled to true

Expected behavior
The chunks cache and results memcached starts up with persistence enabled

@AndreZiviani
Copy link
Contributor

In #13619 that adds persistent memcached, the default chart values lead to a failure of memcached to start

my bad, implementing a fix for this now

However the docs on this at https://github.com/memcached/memcached/wiki/ConfiguringLokiExtstore indicate a few more settings need changing or optimising

this doc was made before Loki version 3.0, I have based the implementation on this blog post which does not set those values (at least it was not mentioned), but you can always add them yourself via extraExtendedOptions

Simply enabling ext cache without doing any of the other performance tweaks I worry could lead users to a subpar experience?

I don't think so but like I said you can always add them yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants