Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track when builders are doing work with a gauge #13570

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

This PR adds a gauge metric to check when the builder is actually doing work.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts force-pushed the salvacorts/bloom-refactor/metric-builder-working branch 2 times, most recently from b661763 to 8373fb8 Compare July 18, 2024 10:27
@salvacorts salvacorts marked this pull request as ready for review July 18, 2024 10:38
@salvacorts salvacorts requested a review from a team as a code owner July 18, 2024 10:38
@salvacorts salvacorts force-pushed the salvacorts/bloom-refactor/metric-builder-working branch from 8373fb8 to 0415d9f Compare July 18, 2024 12:22
@salvacorts salvacorts merged commit 0029d46 into main Jul 18, 2024
61 checks passed
@salvacorts salvacorts deleted the salvacorts/bloom-refactor/metric-builder-working branch July 18, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants