Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try golangci-lint #918

Closed
mstoykov opened this issue Feb 4, 2019 · 2 comments
Closed

Try golangci-lint #918

mstoykov opened this issue Feb 4, 2019 · 2 comments
Labels
ci enhancement high prio

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Feb 4, 2019

There is an alternative to gometalinter - golangci-lint which supposedly is much better in all aspect imaginable, we should probably try and see what the difference is
@na--
Copy link
Member

na-- commented Feb 28, 2019

gometalinter is actually deprecated, so we don't have a lot of choice but to switch to golangci-lint alecthomas/gometalinter#590

@na-- na-- added the high prio label Feb 28, 2019
@na--
Copy link
Member

na-- commented Mar 8, 2019

Closed by #943
I think we should leave gometalinter running in the circleci job for the next few weeks, just to see if there are any discrepancies between the two linters

@na-- na-- closed this as completed Mar 8, 2019
@na-- na-- mentioned this issue Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci enhancement high prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstoykov @na--