Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I cannot configure Instana Datasource #434

Closed
mantoniocc opened this issue Jun 16, 2021 · 1 comment · Fixed by #666
Closed

I cannot configure Instana Datasource #434

mantoniocc opened this issue Jun 16, 2021 · 1 comment · Fixed by #666
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mantoniocc
Copy link

mantoniocc commented Jun 16, 2021

I'm facing a problem similar to this issue and this when I try to configure Instana datasource. I've noticed that all data under jsonData are ignored, then my configMap shows an empty jsonData because of jsonData fields whitelisting.

apiVersion: integreatly.org/v1alpha1
kind: GrafanaDataSource
metadata:
name: grafana-datasources
namespace: grafana
spec:
name: grafana-datasources.yaml
datasources:
- name: Instana
type: instana-datasource
access: direct
orgId: 1
isDefault: true
url: ${INSTANA_UI_BACKEND_URL}
jsonData:
url: ${INSTANA_UI_BACKEND_URL}
apiToken: ${INSTANA_API_TOKEN}
useProxy: false
showOffline: true
allowInfraExplore: true
version: 1
editable: true

This is a reference for provisioning Instana datasource here

It is possible to add the necessary fields or exists any plan to allow in the future to configure third party datasources?

@mantoniocc mantoniocc added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 16, 2021
@hubeadmin
Copy link
Collaborator

hi @mantoniocc , is this something you're willing to provide a PR for? we'll gladly accept, we have examples of how to deal with allowing new fields in datasources already if you're willing to give it a shot, if not, I'll implement it in the future, thanks 👍

@pb82 pb82 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2021
@pb82 pb82 closed this as completed in #666 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants