Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] spec.route.host - field is immutable #1197

Closed
davidkarlsen opened this issue Aug 16, 2023 · 4 comments
Closed

[Bug] spec.route.host - field is immutable #1197

davidkarlsen opened this issue Aug 16, 2023 · 4 comments
Labels
bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@davidkarlsen
Copy link
Contributor

Describe the bug

troller-manager-6558fd8d4d-5wkrx manager 1.6921724618218668e+09     INFO    IngressReconciler       reconciling route       {"controller": "grafana", "controllerGroup": "grafana.integreatly.org", "controllerKind": "Grafana", "Grafana": {"name":"grafana","namespace":"grafana-operator"}, "namespace": "grafana-operator", "name": "grafana", "reconcileID": "66c721f0-7350-4004-9f39-c02069142a08", "platform": "openshift"}
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager 1.6921724618343654e+09     ERROR   GrafanaReconciler       reconciler error in stage       {"controller": "grafana", "controllerGroup": "grafana.integreatly.org", "controllerKind": "Grafana", "Grafana": {"name":"grafana","namespace":"grafana-operator"}, "namespace": "grafana-operator", "name": "grafana", "reconcileID": "66c721f0-7350-4004-9f39-c02069142a08", "stage": "ingress", "error": "Route.route.openshift.io \"grafana-route\" is invalid: spec.host: Invalid value: \"grafana.apps.ftm-aro-dev-nore.dev.payments-paymentengine-dcon.i.tech-05.net\": field is immutable"}
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager github.com/grafana-operator/grafana-operator/v5/controllers.(*GrafanaReconciler).Reconcile
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager    github.com/grafana-operator/grafana-operator/v5/controllers/grafana_controller.go:105
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager    sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:121
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager    sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:320
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager    sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:273
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
grafana-operator-controller-manager-6558fd8d4d-5wkrx manager    sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:234

Version
5.3.0

To Reproduce
Steps to reproduce the behavior:

  1. Create a grafana instance on openshift, and specify spec.route.host

Expected behavior
Should set host field in created route to specified value

Suspect component/Location where the bug might be occurring
See stacktrace

Screenshots
See stacktrace

Runtime (please complete the following information):

  • OS: Linux
  • Grafana Operator Version - as I said, 5.3.0
  • Environment: openshift on azure
  • Deployment type: operator
  • Other: N/A

Additional context
Add any other context about the problem here.

@davidkarlsen davidkarlsen added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 16, 2023
@davidkarlsen
Copy link
Contributor Author

Looks a bit like #646

@NissesSenap
Copy link
Collaborator

Sounds resonable @davidkarlsen.
Could you create a PR to fix it?
You can take inspiration from: #644

@davidkarlsen
Copy link
Contributor Author

@NissesSenap PTAL at my draft PR

@NissesSenap
Copy link
Collaborator

solved in #1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants