React Native instrumentation package #241
Draft
+1,961
−1,516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskirk
commented
Aug 9, 2023
| @@ -45,9 +47,9 @@ export const isPrimitive = ((value) => !isObject(value) && !isFunction(value)) a | |||
| string | number | bigint | boolean | symbol | |||
| >; | |||
|
|
|||
| export const isEventDefined = !isUndefined(Event); | |||
| export const isEventDefined = !isUndefined(globalObject?.Event); | |||
There was a problem hiding this comment.
Couldn't get a polyfill of Event to work, so instead just adding some error protection. Otherwise in the React Native environment you would get a "ReferenceError.... Cannot find variable: Event"
3 tasks
in order for us to be able to merge this we would need
once we have those in, the team could do some reviews on the changes and potentially add this as an experimental feature. if you were able to do some work on this I would be happy to do some reviews. I just unfortunately do not have the time to finish up this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For August 2023 Hackathon