Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate dynamically if granularity is not set #150

Open
Jaehui-Lee opened this issue Mar 8, 2023 · 1 comment
Open

Calculate dynamically if granularity is not set #150

Jaehui-Lee opened this issue Mar 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Jaehui-Lee
Copy link

Jaehui-Lee commented Mar 8, 2023

When sending a query, it would be nice to have a function that dynamically calculates the granularity when the granularity is not set.

In the (old) plugin I am currently using, if 'custom granularity' is not set, it is converted as follows:

interval granularity
24 hour 15 minutes
1 month 1 hour
1 year 1 month

etc.

I guess with this part (https://github.com/grafana-druid-plugin/druidplugin/blob/33af5d544755a7bbcf7d72fcbd9673ef66a2840c/src/datasource.ts#L67)

However, when I tested the new version, I found that the feature is not there.
Currently, when I set Granularity to 'Simple:minute', 1 hour, 1 week, 1 month, and 1 year intervals all use granularity as minute.
If the number of panels is large and the time interval is long, refreshing can take a long time and consume a lot of memory due to the large amount of data being returned.

The version I am currently using is:
Grafana: v5.4.5
druid plugin : v0.0.5

The version I'm using for testing is:
Grafana: v9.3.6
druid plugin: v1.4.1

thank you !

@jbguerraz
Copy link
Contributor

Hello @Jaehui-Lee
That would be an interesting feature indeed! Would you like to contribute it ? I'd be happy to help!

@jbguerraz jbguerraz added the enhancement New feature or request label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants