Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gr.utils.delete_none only delete props that are None, not values that contain None #3183

Closed
1 task done
abidlabs opened this issue Feb 12, 2023 · 0 comments · Fixed by #3188
Closed
1 task done

Make gr.utils.delete_none only delete props that are None, not values that contain None #3183

abidlabs opened this issue Feb 12, 2023 · 0 comments · Fixed by #3188
Assignees
@abidlabs
Labels
bug Something isn't working

Comments

@abidlabs
Copy link
Member

Describe the bug

Right now, the implementation of gr.utils.delete_none deletes any None found anywhere inside of a config dictionary, even if it is nested inside of a tuple / dict / etc. This implementation is buggy, as discussed here: internal Slack

We should rewrite this function

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

N/A

Screenshot

No response

Logs

N/A

System Info

All

Severity

serious, but I can work around it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abidlabs abidlabs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes gr.utils.delete_none gradio-app/gradio
1 participant
@abidlabs