fix: improve downloadButton

[spaenleh]

Before:

Now:

fix #920

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[ReidyT]

Really nice, LGTM! I just have two questions:

1. It is possible to display the extension even with the item name?
2. It is possible to display a special icon depending on the file? (pdf icon, ppt icon, etc). I think this one can be in another issue.

[spaenleh]

@ReidyT

1. I was thinking about adding an indication for the format of the file (I can get it from the mimetype). But not as an extension, more like on the second line next to the size ? Or we could display the original file name, but there is no way for the user to change it, so it would not be a good design I think.
2. Since for the moment we are showing this button for file formats we do not support, it would be difficult to display the right logo, but I can see a use where people want a supported element to be displayed as a downloadable element (audio already allows to donwload via the native element), but imagine you want to display the pdf as a button and not as an embed.

[ReidyT]

@ReidyT

1. I was thinking about adding an indication for the format of the file (I can get it from the mimetype). But not as an extension, more like on the second line next to the size ? Or we could display the original file name, but there is no way for the user to change it, so it would not be a good design I think.
2. Since for the moment we are showing this button for file formats we do not support, it would be difficult to display the right logo, but I can see a use where people want a supported element to be displayed as a downloadable element (audio already allows to donwload via the native element), but imagine you want to display the pdf as a button and not as an embed.

1. Yeah I think it could be a good idea. On my point of view, it's always interesting to know the type of the file you'll download.
2. I understand that it's not easy, it was more a potential improvement 😄.