fix: item status #626
Merged
fix: item status #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
force-pushed
the
hotfix-item-status
branch
from
127fe8c
to
7f6d1af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where item statuses stopped showing.
There is still a reactivity issue, because the queries are not invalidating correctly, so the statuses do not updates when a single mutation updates them. This needs to be investigated further.Invalidation should now work as expected. One trade-off is that all itemTags queries that target multiple items will refetch when one itemTag is changed. It looks like invalidation of query keys is made in order of the elements in the array, so it is not easily possible to invalidate one of the use many queries if it does not target the first id in the list:
Example of itemTags query keys:
["items", "itemTags", "many", "idA", idB", idC", ...]in this case it is possible to invalidate this query by using one of these:["items"]["items", "itemTags"]["items", "itemTags", "many"]["items", "itemTags", "many", "idA"]But using the following will not work:
["items", "itemTags", "many", "idB"]So currently we use:
["items", "itemTags", "many"]