Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show item login message on customer pages #1460

Merged
merged 5 commits into from
Sep 20, 2024
Merged

feat: show item login message on customer pages #1460

merged 5 commits into from
Sep 20, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Sep 18, 2024 •
edited
Loading

Screen.Recording.2024-09-18.at.12.26.58.mov

@pyphilia pyphilia linked an issue Sep 18, 2024 that may be closed by this pull request
Handle guest users on home page #1452
Closed
@pyphilia pyphilia self-assigned this Sep 18, 2024
@pyphilia pyphilia added bug 🪲 Something isn't working priority Give priority to this issue labels Sep 18, 2024
ReidyT
ReidyT approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! LGTM 🚀

package.json Outdated Show resolved Hide resolved
src/components/main/ItemMenuContent.tsx Outdated Show resolved Hide resolved
spaenleh
spaenleh requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work. 💪

It looks like you are fixing multiple issues in the same PR.

I am not sure why we are doing some verifications on the HomeScreen component when we should already have them embedded with the wrappers defined in App.tsx ?

cypress/e2e/item/view/viewFolder.cy.ts Outdated Show resolved Hide resolved
src/components/App.tsx Show resolved Hide resolved
src/components/item/header/Actions.tsx Show resolved Hide resolved
src/components/pages/home/HomeScreen.tsx Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
@pyphilia pyphilia mentioned this pull request Sep 19, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 7e44954 Sep 20, 2024
4 checks passed
@graasper graasper mentioned this pull request Sep 20, 2024
Merged
@pyphilia pyphilia deleted the 1452-fix-guest-layout branch September 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT ReidyT approved these changes

Assignees

@pyphilia pyphilia

Labels
bug 🪲 Something isn't working priority Give priority to this issue v2.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle guest users on home page
3 participants
@pyphilia @spaenleh @ReidyT