Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: action outputs #352

Merged
merged 5 commits into from
Dec 3, 2021
Merged

feat: action outputs #352

merged 5 commits into from
Dec 3, 2021

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Dec 1, 2021

Closes #351

gr2m
gr2m reviewed Dec 1, 2021
View reviewed changes
Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update .github/workflows/test.yml to include a job testing the outputs? You could also update the existing jobs instead. You can add a step with an if condition to fail the job if the output is not what it should be

README.md Show resolved Hide resolved
@AuHau
Copy link
Contributor Author

AuHau commented Dec 2, 2021

I have implemented your feedback. Please allow the tests to run to see if it works 😉 😅

I have added the unchanged result, but it does not return the PR number. I would leave it like this until somebody would need it. It would require quite a bit of some refactoring of the code to get the PR number already at that stage of the Action.

@gr2m
Copy link
Owner

gr2m commented Dec 2, 2021

I have added the unchanged result, but it does not return the PR number. I would leave it like this until somebody would need it. It would require quite a bit of some refactoring of the code to get the PR number already at that stage of the Action.

good call 👍🏼

gr2m
gr2m reviewed Dec 2, 2021
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@AuHau @gr2m
chore: pr review feedback
efdb9ca 
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
@AuHau AuHau requested review from gr2m December 3, 2021 16:22
@gr2m gr2m merged commit 0bd77d5 into gr2m:master Dec 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m Awaiting requested review from gr2m

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outputs of the action
2 participants
@AuHau @gr2m