Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method GetUploadToken should not be exposed. #9

Closed
pacoorozco opened this issue Jul 30, 2019 · 0 comments · Fixed by #40
Closed

Method GetUploadToken should not be exposed. #9

pacoorozco opened this issue Jul 30, 2019 · 0 comments · Fixed by #40
Milestone
v2.0.0

Comments

@pacoorozco
Copy link
Member

The GetUploadToken method should not be exposed outside this module.

This is a breaking change with no backwards compatibility A new v2 version should be published.

google-photos-api-client-go/lib-gphotos/client.go

Line 60 in f16c909

func (c *Client) GetUploadToken(r io.Reader, filename string) (token string, err error) {

@pacoorozco pacoorozco added this to the v2.0.0 milestone Jul 30, 2019
@pacoorozco pacoorozco mentioned this issue Sep 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

V2 gphotosuploader/google-photos-api-client-go
1 participant
@pacoorozco