Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into migrating away from chrono and directly use time 0.3 #26

Closed
gourlaysama opened this issue Oct 18, 2021 · 2 comments
Closed

Look into migrating away from chrono and directly use time 0.3 #26

gourlaysama opened this issue Oct 18, 2021 · 2 comments

Comments

@gourlaysama
Copy link
Owner

chrono doesn't appear to be maintained anymore.

It depends on a very old version of time which is affected by RUSTSEC-2020-0071 (#25), and itself is affected by the same thing (CVE-2020-26235: chronotope/chrono#602).
@gourlaysama gourlaysama changed the title Migrate away from chrono and directly use time 0.3 Look into migrating away from chrono and directly use time 0.3 Oct 20, 2021
@gourlaysama
Copy link
Owner Author

The time dependency was removed in #27.

@gourlaysama
Copy link
Owner Author

Closing this as not needed:

  • Chrono is seeing more activity these days (although there hasn't been a release since 2020)
  • We don't use the dangerous code paths here (we don't really need the local offset in the first place),
  • We require chrono's unstable-locales to display localized versions of the date/time obtained from OpenWeather (every other use of chrono can be done with just time 0.3)

@gourlaysama gourlaysama closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gourlaysama