-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🖥 🔧 Svelte #19
Comments
Yes! This sounds like a great idea. I'm on vacation at the moment but let me see if anyone out there is up for making a start on this |
Svelte beginner here. Not sure if can do this fully on my own, as i have not much idea about routing and data access part. But will be happy to contribute to the project. |
@esakkiraj okay! I say go ahead and get started, and when you run into things you need help on, lets ping @Rich-Harris and see if he (or someone he knows in the Svelte community) can help answer your q's :) |
@EricSimons Okay then. I will start working on this. 👍 |
@esakkiraj ping me if you need any help |
@esakkiraj Have you forked the starter repo yet? If so, can you drop a link so we can add it to this issue? |
@silentworks Sure. Thanks @BRWR Yes i have forked. Have started the work. But havent' pushed the changes yet. Repo Link |
@esakkiraj just updated issue status w/ gitter room! Also, created this logo you can use for the readme: |
Hey all — just to let you know I spent the day working on a Sapper implementation of this (Sapper is a Next.js-style framework for Svelte that's currently in development). It's not quite finished, but it's most of the way there. |
@Rich-Harris woah, this is awesome! Great work! Lmk once it's completely there and I'll list it on the main readme 👍 |
I think this is basically done — if you could add it to the official list, that'd be great, thanks! A question: how much freedom do we have to interpret the requirements? I ask because I have an alternative version here: https://svelte-realworld-oegnyylkph.now.sh. (It seems to be a bit flaky at the moment but I think that's https://conduit.productionready.io/api, which appears to be having some problems — other implementations seem to be affected too). The main difference is that there are some new routes:
As well as deeplinking, this makes it easy to server-render those pages (with Sapper, you get SSR for free), and prefetch them when the user is about to tap on a link. Personally I think it results in a snappier-feeling app than flickering between an article list and '...loading articles', though that's possibly subjective. |
@Rich-Harris awesome work! Adding this to the readme now 👍 Btw what problems are you running into with the public API endpoint? We haven't seen/heard of any issues with it as of late 🤔 |
Wow, super weird - cc/ @apai4 (creator/maintainer of the public api server) BTW all of your ux/route/etc changes are totally fine- forgot to mention that in my last comment :) |
@Rich-Harris @EricSimons the 429 error is from rate limiting on the API to help prevent spam/abuse, since every once in a while the front pages get flooded with inappropriate content. I just increased the number of requests per minute allowed so let's see if that decreases the number of errors we see. |
@apai4 thanks — that may be partly my fault then, Sapper can do prefetching of links when you mouseover them (with
Thanks — will switch it over to the new branch once I've made those prefetch changes. |
Shouldn't this be removed from the work in progress section as it's alreaday in the "frontend grid"? |
Current Status
Codebase in progress:
esakkiraj/realworld-starter-kit
Interested in helping out? Say hello! 🎉
gitter.im/realworld-dev/svelte
Todo:
The text was updated successfully, but these errors were encountered: