Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 6 + @ngrx/store + nrwl/nx #178

Closed
3 of 5 tasks
stefanoslig opened this issue Jan 29, 2018 · 5 comments
Closed
3 of 5 tasks

Angular 6 + @ngrx/store + nrwl/nx #178

stefanoslig opened this issue Jan 29, 2018 · 5 comments
Labels

Comments

@stefanoslig
Copy link
Contributor

stefanoslig commented Jan 29, 2018

Current Status

Codebase ready for the review:
https://github.com/stefanoslig/angular-ngrx-nx-realworld-example-app

Demo
https://stefanoslig.github.io/angular-ngrx-nx-realworld-example-app

Todo:

  • 🏁Fork the starter repo & post the link in this issue
  • 🎨 Create logo for repo
  • 🔨 Implement all of Conduit's functionality per the spec & API
  • 👀 Peer review of final codebase by RealWorld admins & community (RFC)
  • 🎉Tag v1 release, move repo to main org, and officially list it on the README!
@stefanoslig
Copy link
Contributor Author

stefanoslig commented Feb 25, 2018

@EricSimons , @Cameron-C-Chapman The codebase is ready for the review. Thank you in advance!

@Cameron-C-Chapman Cameron-C-Chapman added rfc and removed wip labels Mar 9, 2018
@stefanoslig stefanoslig changed the title Angular 5 + @ngrx/store + nrwl/nx Angular 6 + @ngrx/store + nrwl/nx Aug 6, 2018
@stefanoslig
Copy link
Contributor Author

Hello guys, is there any chance to add this project in the main list or in the WIP list? It's in the same status for so long time. Thank you!

@anishkny
Copy link
Member

anishkny commented Aug 8, 2018

@stefanoslig sorry for the delay. I played around with the deployed app and also locally and things look good overall!

I tried to execute tests but did not work:

npm test

## This shows up in browser:
AppComponent should create
Failed: Template parse errors:
Can't bind to 'isLoggedIn' since it isn't a known property of 'app-navbar'.
1. If 'app-navbar' is an Angular component and it has 'isLoggedIn' input, then verify that it is part of this module.
2. If 'app-navbar' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.

It would be good to document in the README how to run tests, and link to TravisCI/CircleCI if you have it setup.

@stefanoslig
Copy link
Contributor Author

hello @anishkny. Thanks for your response. I updated the README as you mentioned and npm test now is working. I need to work on unit tests for libs and this will be one of my first priorities. Of course if someone wants to help, any help is more than welcome.

@Cameron-C-Chapman
Copy link
Member

Hi @stefanoslig. This looks awesome 😄

All the tests are passing but I do see some strange behavior where after the initial 3 tests pass the console doesn't free up, and when I try to kill it, it kicks off some new compilation and take a few tries to kill the console. That could just be my machine but something to be aware of.

It looks good to me, we'll get it added to the main readme soon. Thanks for putting it together 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants