-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 6 + @ngrx/store + nrwl/nx #178
Comments
@EricSimons , @Cameron-C-Chapman The codebase is ready for the review. Thank you in advance! |
Hello guys, is there any chance to add this project in the main list or in the WIP list? It's in the same status for so long time. Thank you! |
@stefanoslig sorry for the delay. I played around with the deployed app and also locally and things look good overall! I tried to execute tests but did not work:
It would be good to document in the README how to run tests, and link to TravisCI/CircleCI if you have it setup. |
hello @anishkny. Thanks for your response. I updated the README as you mentioned and npm test now is working. I need to work on unit tests for libs and this will be one of my first priorities. Of course if someone wants to help, any help is more than welcome. |
Hi @stefanoslig. This looks awesome 😄 All the tests are passing but I do see some strange behavior where after the initial 3 tests pass the console doesn't free up, and when I try to kill it, it kicks off some new compilation and take a few tries to kill the console. That could just be my machine but something to be aware of. It looks good to me, we'll get it added to the main readme soon. Thanks for putting it together 🎉 |
Current Status
Codebase ready for the review:
https://github.com/stefanoslig/angular-ngrx-nx-realworld-example-app
Demo
https://stefanoslig.github.io/angular-ngrx-nx-realworld-example-app
Todo:
The text was updated successfully, but these errors were encountered: