Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show verbose listing of mods in alphabetical order #315

Closed
jokrefta opened this issue May 6, 2023 · 4 comments
Closed

Show verbose listing of mods in alphabetical order #315

jokrefta opened this issue May 6, 2023 · 4 comments
Labels
priority I am working on it, or will soon

Comments

@jokrefta
Copy link

jokrefta commented May 6, 2023

The Problem

ferium list shows mods in alphabetical order. However, ferium list -v does not.

Your Solution(s)

It would be nice to at least have the option of sorting in alphabetical order when doing the verbose listing, or just have it sorted that way by default.

@khuongduy354
Copy link

Is anyone doing this? If not, let me have a look.

@khuongduy354
Copy link

https://github.com/khuongduy354/ferium/blob/main/src/main.rs#L205
The mods list is sorted beforehand. But ferium list run synchronously, while ferium list --verbose does not (ran asyncly with tokio), hence it printed in random order. I'm still a newbie, and have a few questions, hope you can explain, just a few of it if you're busy.

  1. Why the mardown version doesn't need tokio, while the verbose version does, is it performance or something?
  2. Why the modrinth in line 210 not called directly, but need to add to list and call later?
  3. Can i make it so that both markdown and verbose print looks more consistent. Either both has tokio, or both has tokio removed?

@theRookieCoder
Copy link
Collaborator

Sorry for leaving you hanging @khuongduy354, I know the list code is a bit of a mess. I'll answer your questions when I take a look at the code and implement this issue.

@khuongduy354
Copy link

It's ok, take ur time

@theRookieCoder theRookieCoder added the priority I am working on it, or will soon label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority I am working on it, or will soon
Development

No branches or pull requests

3 participants