Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] "Couldn't find the scrollable node handle id!" console warning printed from BottomSheetScrollView in tests #1918

Closed
piotr-sobczyk opened this issue Aug 16, 2024 · 1 comment
Labels

Comments

@piotr-sobczyk
Copy link

Bug

After bumping to 4.6.3 to, when the BottomSheetScrollView component is rendered in jest environment it now prints the following console.warn():

Couldn't find the scrollable node handle id!

Other than that, everything is fully functional in runtime and test environment.

It's mostly a result of this change: #1823 (but console.warn is still much better than the Unexpected nativeTag: object; nativeTag=undefined error that was thrown before 🙏 🙏 )

Environment info

Library Version
@gorhom/bottom-sheet 4.6.3
react-native 0.74.5
react-native-reanimated 3.10.1
react-native-gesture-handler 2.16.2

Steps To Reproduce

  1. Execute a jest tests that is rendering any component tree including BottomSheetScrollView
  2. "Couldn't find the scrollable node handle id!" warning is printed

Describe what you expected to happen:

I expected no console.warns to be printed.

Printing useless console warnings is a bad pattern and especially annoying in setups like ours when using jest-fail-on-console to disallow any console logs in tests execution.

@piotr-sobczyk piotr-sobczyk added the bug Something isn't working label Aug 16, 2024
Copy link

@piotr-sobczyk: hello! 👋

This issue is being automatically closed because it does not follow the issue template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant