Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] | handleHeight Prop exists in documentation and not in type definitions #1881

Closed
giantslogik opened this issue Jul 10, 2024 · 5 comments
Labels
bug Something isn't working no-issue-activity

Comments

@giantslogik
Copy link

Bug

In 5.0.0-alpha.10 the prop handleheight is described here.
https://ui.gorhom.dev/components/bottom-sheet/props#handleheight

However it doesn't actually exist in the typedefinitions.

Environment info

Library Version
@gorhom/bottom-sheet 5.0.0-alpha.10
react-native 0.73.6
react-native-reanimated 3.13.0
react-native-gesture-handler 2.16.2

Steps To Reproduce

  1. Use the prop handleHeight:

Describe what you expected to happen:

  1. Prop works

Reproducible sample code

        <BottomSheet
          backdropComponent={renderBackdrop}
          onChange={localOnChange}
          onAnimate={localOnAnimate}
          animateOnMount={false}
          enableContentPanningGesture={false}
          enablePanDownToClose
          handleComponent={component}
          handleHeight={48}
          index={-1}
          onAnimate={handleAnimate}
          ref={bottomSheetRef}
          snapPoints={snapPoints}
        >
          {children}
        </BottomSheet>
@giantslogik giantslogik added the bug Something isn't working label Jul 10, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@caspg
Copy link

caspg commented Oct 20, 2024

I experienced same error with the latest version 5.04.

@khushal87
Copy link

@gorhom is it expected?

@waynes-labs
Copy link

It looks like it was taken out in #1683 but the docs were not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

4 participants