Skip to content

Commit

Permalink
Visually separate scriptlet parameters in active line
Browse files Browse the repository at this point in the history
This makes it easier to see how parameters are parsed internally,
in order to make it easier to distinguish commas as separator and
literal commas meant to be part of a parameter.

Related discussion:
uBlockOrigin/uBlock-discussions#865 (reply in thread)
  • Loading branch information
gorhill committed Dec 4, 2024
1 parent 7848884 commit 076e9fa
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/css/codemirror.css
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@
.cm-theme-override .cm-s-default .cm-variable {
color: var(--sf-variable-ink);
}
.cm-theme-override .cm-s-default .CodeMirror-activeline .cm-ext-js .cm-variable {
text-decoration: underline color-mix(in srgb, var(--sf-variable-ink) 30%, transparent) solid 3px;
text-decoration-skip-ink: none;
}
.cm-theme-override .cm-s-default .cm-warning {
background-color: var(--sf-warning-surface);
text-decoration: underline var(--sf-warning-ink);
Expand Down

3 comments on commit 076e9fa

@troysjanda
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to read the comments but I get a 404 error when clicking that link

https://github.com/uBlockOrigin/uBlock-discussions/discussions/865#discussioncomment-11461980

@MasterKia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an internal discussion only available for contributors.

@troysjanda
Copy link

@troysjanda troysjanda commented on 076e9fa Dec 5, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.