Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing pathlib.Path to Observer.schedule() causes a trap in Observer.start() on MacOS #651

Closed
rec opened this issue Feb 26, 2020 · 1 comment
Closed

Passing pathlib.Path to Observer.schedule() causes a trap in Observer.start() on MacOS #651

rec opened this issue Feb 26, 2020 · 1 comment
Labels
bug

Comments

@rec
Copy link
Contributor

rec commented Feb 26, 2020

(This is not a regression of #26! :-))

See this minimal example: https://github.com/rec/backer/blob/bpt-trap/bpt_trap.py

On MacOS, it causes a BPT trap Compilation trace/BPT trap: 5 (something like a SEGV if you are Linux person) on Python 3.6.6, Python 3.7.0, and Python 3.8.1 exactly if PATH is a pathlib.Path.

The workaround is to cast the Path to a str before calling Observer.schedule().
@rec rec changed the title Passing pathlib.Path to Observer.schedule() causes a trap in Observer.start() Passing pathlib.Path to Observer.schedule() causes a trap in Observer.start() on MacOS Feb 26, 2020
rec added a commit to rec/watchdog that referenced this issue Feb 26, 2020
@rec
Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
c00d914
rec added a commit to rec/watchdog that referenced this issue Apr 28, 2020
@rec
Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
6600216
rec added a commit to rec/watchdog that referenced this issue Apr 28, 2020
@rec
Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
8823d36
rec added a commit to rec/watchdog that referenced this issue Apr 28, 2020
@rec
Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
55c6737
rec added a commit to rec/watchdog that referenced this issue Apr 28, 2020
@rec
Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
d2280d4
rec added a commit to rec/watchdog that referenced this issue Apr 28, 2020
@rec
Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
1321592
rec added a commit to rec/watchdog that referenced this issue Apr 28, 2020
@rec
fixup! Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
971e009
rec added a commit to rec/watchdog that referenced this issue Apr 28, 2020
@rec
Ensure ObservedWatch.path is a string (fix gorakhargosh#651)
fa78e7e
@BoboTiG BoboTiG added the bug label Apr 28, 2020
@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 28, 2020

Fixed in #652.

@BoboTiG BoboTiG closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rec @BoboTiG