Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues report and suggestion #993

Open
1 of 4 tasks
cpunion opened this issue Feb 15, 2025 · 0 comments
Open
1 of 4 tasks

Issues report and suggestion #993

cpunion opened this issue Feb 15, 2025 · 0 comments
Labels
proposal Proposal

Comments

@cpunion
Copy link
Contributor

cpunion commented Feb 15, 2025

Some issues impacting development progress, and has some potential problems.

Defer implementation

Closure stubs implementation

Issue reference: #983

  • Can't get function address from any type
  • Blocks reuse of go standard library sources:

Patching

  • Incorrect unsafe.Sizeof(sync.Mutex{}), it be parsed to a constant of sync.Mutex size by x/tools, not the size of pthread_mutex_t.
  • Maybe cause some potential problems, reuse more go runtime sources is better.
    • reflect.Value not fully patched

Overlay

  • It can be replaced by patching for better compatible, if defer in loop be resolved, only net/textproto/textproto.go need patching.
/opt/homebrew/Cellar/go/1.24.0/libexec/src/net/textproto/textproto.go:37:2: no required module provides package github.com/goplus/llgo/runtime/internal/clite; to add it:
	go get github.com/goplus/llgo/runtime/internal/clite
cannot build SSA for package github.com/goplus/llgo/runtime/internal/clite
/opt/homebrew/Cellar/go/1.24.0/libexec/src/net/textproto/textproto.go:38:2: no required module provides package github.com/goplus/llgo/runtime/internal/clite/net; to add it:
	go get github.com/goplus/llgo/runtime/internal/clite/net
cannot build SSA for package github.com/goplus/llgo/runtime/internal/clite/net
/opt/homebrew/Cellar/go/1.24.0/libexec/src/net/textproto/textproto.go:39:2: no required module provides package github.com/goplus/llgo/runtime/internal/clite/os; to add it:
	go get github.com/goplus/llgo/runtime/internal/clite/os
cannot build SSA for package github.com/goplus/llgo/runtime/internal/clite/os
/opt/homebrew/Cellar/go/1.24.0/libexec/src/net/textproto/textproto.go:40:2: no required module provides package github.com/goplus/llgo/runtime/internal/runtime; to add it:
	go get github.com/goplus/llgo/runtime/internal/runtime
@xushiwei xushiwei added the proposal Proposal label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposal
Projects
None yet
Development

No branches or pull requests

2 participants