fix(renderer): fix marker position #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <circle cx="120" cy="120" opacity=".6" r="70" /> | ||
| <circle cx="120" cy="120" opacity=".3" r="90" /> | ||
| <circle cx="120" cy="120" opacity=".2" r="110" /> | ||
| <text x="50%" y="50%" style="fill:#fff" text-anchor="middle" font-size="50" dominant-baseline="middle" font-family="roboto,arial,sans-serif">${count}</text> |
Check warning
Code scanning / CodeQL
Unsafe HTML constructed from library input
amuramoto
approved these changes
Jun 6, 2023
amuramoto
approved these changes
Jun 6, 2023
googlemaps-bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
### [2.2.2](v2.2.1...v2.2.2) (2023-06-06) ### Bug Fixes * **renderer:** fix marker position ([#667](#667)) ([fbb8fa8](fbb8fa8)) ### Code Refactoring * misc minor cleanup ([#657](#657)) ([31cc4f6](31cc4f6)) ### Miscellaneous Chores * **deps-dev:** bump @rollup/plugin-node-resolve from 15.0.2 to 15.1.0 ([#662](#662)) ([6a90770](6a90770)) * **deps-dev:** bump @typescript-eslint/eslint-plugin ([#664](#664)) ([5089ca9](5089ca9)) * **deps-dev:** bump @typescript-eslint/parser from 5.59.8 to 5.59.9 ([#665](#665)) ([57d761c](57d761c)) * **deps-dev:** bump eslint from 8.41.0 to 8.42.0 ([#666](#666)) ([248b081](248b081)) * **deps-dev:** bump typedoc from 0.24.7 to 0.24.8 ([#663](#663)) ([f52e44d](f52e44d)) * Update release.yml ([7b9503e](7b9503e))
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes #643 for both advanced and legacy markers
Before:
After:
You can see that the center of the group cluster is now correctly positioned at the average of pin tips.
More changes:
The code now uses the same SVG for both legacy and advanced markers.
Labels were a big perf hit with legacy markers as it was causing a call to
getClientBoundingRect.Perf for legacy markers should be significantly improved.
I removed the whitespaces in the SVG literal. Because we don't want to pay the size + the extra parser time for them. Small diff but why not (readability is still ok I think).