-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove memory leak in Task. #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks the following code example:
const googleMapsClient = require('@google/maps').createClient({
key: 'YOUR API TOKEN'
});
setInterval(() => {
googleMapsClient.geocode({
address: '1600 Amphitheatre Parkway, Mountain View, CA'
}, function(err, response) {
console.log(err, response.json.results[0].formatted_address);
});
}, 150);
Changing this fix like this priidikvaikla@658b32f would get it working for me again. But still I see slight increase in memory consumption. |
Yes, thanks, you're right that my PR is wrong. I still haven't got to the bottom of this though. It's still leaking memory, and it looks like maybe a problem in a different place. |
Also delete the abort callback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now memory consumption doesn't increase anymore
I was just wondering when we might see a patch bump to this library that will include this change? Thanks for all the hard work! |
Awesome work! 👍 We are also eagerly waiting for a new release :) |
Fixes #71