Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "origin" parameter to the placesAutoComplete function #245

Merged
merged 3 commits into from
Jun 10, 2019

Conversation

nagy-tamas
Copy link
Contributor

Without passing the origin parameter to the placesAutoComplete() function we can't get the distance of the result items from our specified location.
(result.json.predictions[n]distance_meters in the response).

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@nagy-tamas
Copy link
Contributor Author

@googlebot .

@amuramoto
Copy link
Member

@nagy-tamas Please add tamas.nagy@apps.no to your CLA, then I can accept the PR. Thanks!

You can login here to update:

https://cla.developers.google.com/

@nagy-tamas
Copy link
Contributor Author

@nagy-tamas Please add tamas.nagy@apps.no to your CLA, then I can accept the PR. Thanks!

You can login here to update:

https://cla.developers.google.com/

Thanks, it's done.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@amuramoto amuramoto merged commit 9e90e84 into googlemaps:master Jun 10, 2019
@amuramoto
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants