fixes pagination INVALID_REQUEST handling #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domesticmouse @stephenmcd if either of you is familiar with this codebase, can you sanity check this? Basically, if pagetoken is sent too soon the API returns INVALID_REQUEST status, and the util was not properly handling this in the retry logic. |
|
The failing Travis tests looks like it needs some maintenance. I'm guessing the API keys were once used securely by the testing infrastructure, but it no longer works? But, I really don't know anything about this codebase. It's really @stephenfarrar and @stephenmcd who know the most about it. Sorry! |
|
Thanks @domesticmouse! Yeah Travis is failing because the secure env vars are not available to PRs. Everything is passing locally for me. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a next_page_token is returned for nearby places searches, an INVALID_REQUEST status is returned if the token is sent too quickly. This fixes retry logic for this case, and reenables a pagination test that was previously failing because of this.