Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region parameter to Text Search API #131

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

antonio0
Copy link
Contributor

With this change client.places() can accept the region parameter.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@antonio0
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@TarekDeeb
Copy link

Any ETA on when this will be merged?

@antonio0
Copy link
Contributor Author

I'm assuming it has gone unnoticed? @stephenmcd

The region is a supported parameter and as of now it doesn't work with this client https://developers.google.com/places/web-service/search#TextSearchRequests

@signorekai
Copy link

Any ETA with this PR?

@stephenmcd
Copy link
Contributor

Any ETA with this PR?

ASAP :-)

@stephenmcd
Copy link
Contributor

Thanks Antonio, sorry about the delay.

@stephenmcd stephenmcd closed this Feb 12, 2018
@stephenmcd stephenmcd reopened this Feb 12, 2018
@stephenmcd stephenmcd merged commit b0aa5ea into googlemaps:master Feb 12, 2018
hysan added a commit to hysan/react-native-google-maps-services that referenced this pull request Feb 13, 2018
@Jekiwijaya
Copy link

Sorry. Newbie here.

when this feature published in npm?

@stephenmcd
Copy link
Contributor

I'm unable to publish a new version right now unfortunately. I've opened an issue with npm here:

npm/npm#20098

Once that's resolved I'll push the new version.

@stephenmcd
Copy link
Contributor

New version is on npm now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants